(FM-7602) Implement Resource API transports for bolt and ACE #73

DavidS · 2018-12-10T18:04:19Z

No description provided.

codecov · 2018-12-10T18:06:29Z

Codecov Report

Merging #73 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   98.98%   99.02%   +0.03%     
==========================================
  Files          36       39       +3     
  Lines         888      919      +31     
==========================================
+ Hits          879      910      +31     
  Misses          9        9

Impacted Files	Coverage Δ
lib/puppet/util/task_helper.rb	`100% <100%> (ø)`
lib/puppet/provider/panos_path_monitor_base.rb	`100% <100%> (ø)`	⬆️
lib/puppet/provider/panos_static_route_base.rb	`100% <100%> (ø)`	⬆️
lib/puppet/provider/panos_commit/panos_commit.rb	`100% <100%> (ø)`	⬆️
lib/puppet/util/network_device/panos/device.rb	`100% <100%> (ø)`	⬆️
lib/puppet/transport/schema/panos.rb	`100% <100%> (ø)`
...nos_arbitrary_commands/panos_arbitrary_commands.rb	`100% <100%> (ø)`	⬆️
lib/puppet/provider/panos_provider.rb	`100% <100%> (ø)`	⬆️
lib/puppet/transport/panos.rb	`100% <100%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837b319...d82ae93. Read the comment docs.

lib/puppet/transport/panos.rb

DavidS · 2019-02-01T19:42:52Z

this is now starting to look like something. can still be cleaned up, but at least is passing tests.

DavidS · 2019-02-13T09:47:47Z

Closing to clean up stuck PR test statusses from travis

da-ar · 2019-02-25T11:54:55Z

Gemfile

  gem "puppet-module-posix-default-r#{minor_version}", require: false, platforms: [:ruby]
  gem "puppet-module-posix-dev-r#{minor_version}",     require: false, platforms: [:ruby]
  gem "puppet-module-win-default-r#{minor_version}",   require: false, platforms: [:mswin, :mingw, :x64_mingw]
  gem "puppet-module-win-dev-r#{minor_version}",       require: false, platforms: [:mswin, :mingw, :x64_mingw]
  gem "webmock",                                       require: false
  gem "builder", '~> 3.2.2',                           require: false
  gem "puppet-strings",                                require: false, git: 'https://github.com/puppetlabs/puppet-strings.git', ref: 'master'
-  gem "puppet-resource_api",                           require: false, git: 'https://github.com/puppetlabs/puppet-resource_api.git', ref: 'master'
+  gem "puppet-resource_api",                           require: false, git: 'https://github.com/puppetlabs/puppet-resource_api.git', ref: 'transport'


This will need to be changed to master when RSAPI is released

this has been release, we can switch back to the gem?

lib/puppet/transport/schema/panos.rb

willmeek · 2019-03-04T14:20:55Z

Apologies for the force push.

As per discussion with @da-ar , changed the APIKey task JSON rather than working around the existing. Much cleaner.

da-ar · 2019-03-08T18:34:49Z

With the task_helper the PANOS module will complain about the following. We will need to make provisions within RSAPI to handle these values correctly during validation.

stderr: Warning: The connection info provided does not match the Transport Schema for panos[]
Unknown attribute:
* run-on
* remote-transport
* name
* uri
* protocol

lib/puppet/util/task_helper.rb

adreyer

The main problem I see is that the task_helper still relies on pluginsync.

tasks/apikey.rb

Experimental implementation of a `panos` transport based on the new in development transport support. This still needs some cleanups before it can be merged. Follow the TODO breadcrumbs.

da-ar · 2019-03-13T09:24:15Z

@DavidS latest changes here will not pass CI until puppetlabs/puppet-resource_api#161 goes into master

DavidS · 2019-03-13T11:31:49Z

merged puppetlabs/puppet-resource_api#161

The files created by basic_spec.rb need to be cleaned up after each run, so they do not get re-used on the next acceptance test run.

da-ar · 2019-03-14T14:48:49Z

@DavidS updates look good to me, but Rubocop is unhappy

Changed task_helper around to get shipped with the task files.

DavidS

A manual run of the acceptance tests passed on my machine, and bolt was able to run a task from the CLI:

david@davids:~/git/puppetlabs-panos$ bundle exec bolt --inventoryfile ./inventory.yaml --transport remote -n x --modulepath ./spec/fixtures/modules/ task run panos::apikey
Started on jryp6xj57njqg6d.delivery.puppetlabs.net...
Finished on jryp6xj57njqg6d.delivery.puppetlabs.net:
  {
    "apikey": "LUFRPT14MW5xOEo1R09KVlBZNnpnemh0VHRBOWl6TGM9bXcwM3JHUGVhRlNiY0dCR0srNERUQT09"
  }
Successful on 1 node: jryp6xj57njqg6d.delivery.puppetlabs.net
Ran on 1 node in 2.82 seconds
david@davids:~/git/puppetlabs-panos$

adreyer reviewed Dec 10, 2018

View reviewed changes

lib/puppet/transport/panos.rb Outdated Show resolved Hide resolved

DavidS force-pushed the transport branch from 41c8a27 to 31687ab Compare January 17, 2019 14:45

DavidS force-pushed the transport branch 5 times, most recently from 3309421 to 645f02c Compare February 1, 2019 19:41

Update to PDK 1.9.0

683848d

DavidS closed this Feb 13, 2019

DavidS reopened this Feb 13, 2019

DavidS force-pushed the transport branch 2 times, most recently from 28c80b1 to a18bb23 Compare February 13, 2019 10:33

da-ar reviewed Feb 25, 2019

View reviewed changes

willmeek force-pushed the transport branch from fe219a3 to e24602e Compare March 4, 2019 14:20

da-ar force-pushed the transport branch 2 times, most recently from 906f991 to 2ed1024 Compare March 8, 2019 18:33

da-ar force-pushed the transport branch from 2ed1024 to 20ba856 Compare March 11, 2019 10:28

adreyer reviewed Mar 11, 2019

View reviewed changes

lib/puppet/util/task_helper.rb Outdated Show resolved Hide resolved

adreyer reviewed Mar 11, 2019

View reviewed changes

lib/puppet/util/task_helper.rb Outdated Show resolved Hide resolved

adreyer previously requested changes Mar 11, 2019

View reviewed changes

tasks/apikey.rb Outdated Show resolved Hide resolved

da-ar force-pushed the transport branch 2 times, most recently from 930bad6 to 9d8d3b7 Compare March 12, 2019 11:21

DavidS and others added 3 commits March 12, 2019 13:55

(FM-7602) Implement the panos Transport

1cd5703

Experimental implementation of a `panos` transport based on the new in development transport support. This still needs some cleanups before it can be merged. Follow the TODO breadcrumbs.

(FM-7602) Update tasks to work with Bolt and RSAPI Transports

2d4a884

(BOLT-994) Task helper for remote resources

9bf1970

da-ar force-pushed the transport branch 3 times, most recently from 417d376 to b36aab0 Compare March 13, 2019 09:23

DavidS changed the title ~~Transport Sketch~~ (FM-7602) Implement Resource API transports for bolt and ACE Mar 13, 2019

DavidS added the feature New feature or request label Mar 13, 2019

da-ar added 3 commits March 13, 2019 17:27

(FM-7602) Handle sensitive values

81eb4c1

(FM-7602) Return correct error structure for bolt

88daa1d

(FM-7602) Update Readme and Reference docs

b08a380

da-ar force-pushed the transport branch from 7fed9a0 to b08a380 Compare March 13, 2019 17:28

(FM-7602) Update acceptance tests

12f236d

da-ar force-pushed the transport branch from daba8c5 to 12f236d Compare March 13, 2019 20:23

DavidS added 3 commits March 14, 2019 11:11

(maint) update to pdk-templates heads/master-0-gfde5699

1bd5b5b

(maint) use puppet-resource_api gem release

2429681

(maint) clean up after acceptance tests

4ad35ec

The files created by basic_spec.rb need to be cleaned up after each run, so they do not get re-used on the next acceptance test run.

(FM-7602) Update store_config to work with Bolt and RSAPI Transports

aff5699

DavidS force-pushed the transport branch from c524b01 to aff5699 Compare March 14, 2019 14:58

(maint) remove obsolete geppetto file

d82ae93

DavidS commented Mar 14, 2019

View reviewed changes

DavidS merged commit 7c5e590 into puppetlabs:master Mar 14, 2019

DavidS mentioned this pull request Mar 14, 2019

(demo) Update apikey task to be a puppet remote task #70

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(FM-7602) Implement Resource API transports for bolt and ACE #73

(FM-7602) Implement Resource API transports for bolt and ACE #73

DavidS commented Dec 10, 2018

codecov bot commented Dec 10, 2018 •

edited

Loading

DavidS commented Feb 1, 2019

DavidS commented Feb 13, 2019

da-ar Feb 25, 2019

DavidS Mar 12, 2019

willmeek commented Mar 4, 2019

da-ar commented Mar 8, 2019

adreyer left a comment

da-ar commented Mar 13, 2019

DavidS commented Mar 13, 2019

da-ar commented Mar 14, 2019

DavidS left a comment

(FM-7602) Implement Resource API transports for bolt and ACE #73

(FM-7602) Implement Resource API transports for bolt and ACE #73

Conversation

DavidS commented Dec 10, 2018

codecov bot commented Dec 10, 2018 • edited Loading

Codecov Report

DavidS commented Feb 1, 2019

DavidS commented Feb 13, 2019

da-ar Feb 25, 2019

Choose a reason for hiding this comment

DavidS Mar 12, 2019

Choose a reason for hiding this comment

willmeek commented Mar 4, 2019

da-ar commented Mar 8, 2019

adreyer left a comment

Choose a reason for hiding this comment

da-ar commented Mar 13, 2019

DavidS commented Mar 13, 2019

da-ar commented Mar 14, 2019

DavidS left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 10, 2018 •

edited

Loading